Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34455 )
Change subject: util/*/Makefile: Rename -W to -Wextra ......................................................................
util/*/Makefile: Rename -W to -Wextra
-W is the old name for -Wextra, so let's rename it to be consistent with the rest of the utility Makefiles.
Change-Id: I0e50f13d2617b785d343707fc895516574164562 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/ectool/Makefile M util/ifdtool/Makefile M util/intelmetool/Makefile M util/inteltool/Makefile M util/nvramtool/Makefile M util/pmh7tool/Makefile M util/viatool/Makefile 7 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/34455/1
diff --git a/util/ectool/Makefile b/util/ectool/Makefile index c4b94da..fdda265 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -15,7 +15,7 @@ ##
CC = gcc -CFLAGS = -O2 -Wall -W +CFLAGS = -O2 -Wall -Wextra PROGRAM = ectool INSTALL = /usr/bin/env install PREFIX = /usr/local diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index 4cddfc5..cc52b1e 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -18,7 +18,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -Werror -I../../src/commonlib/include +CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror -I../../src/commonlib/include LDFLAGS =
OBJS = ifdtool.o diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile index 45a87c7..55ba82a 100644 --- a/util/intelmetool/Makefile +++ b/util/intelmetool/Makefile @@ -17,7 +17,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O0 -g -Wall -W -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function +CFLAGS ?= -O0 -g -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function LDFLAGS += -lpci -lz
OBJS = intelmetool.o me.o me_status.o mmap.o rcba.o msr.o diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index 0f74a7c..cd02fa8 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -22,7 +22,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O2 -g -Wall -W -Wmissing-prototypes +CFLAGS ?= -O2 -g -Wall -Wextra -Wmissing-prototypes LDFLAGS += -lpci -lz
CPPFLAGS += -I$(top)/src/commonlib/include diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 46297a2..c210234 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -19,7 +19,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -I. -DCMOS_HAL=1 +CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall
CLI_OBJS = cli/nvramtool.o cli/opts.o diff --git a/util/pmh7tool/Makefile b/util/pmh7tool/Makefile index 384d3d9..034ed40 100644 --- a/util/pmh7tool/Makefile +++ b/util/pmh7tool/Makefile @@ -14,7 +14,7 @@ ##
CC = gcc -CFLAGS = -O2 -Wall -W -Werror +CFLAGS = -O2 -Wall -Wextra -Werror PROGRAM = pmh7tool INSTALL = /usr/bin/env install PREFIX = /usr/local diff --git a/util/viatool/Makefile b/util/viatool/Makefile index b2a6291..f58cbd3 100644 --- a/util/viatool/Makefile +++ b/util/viatool/Makefile @@ -21,7 +21,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O2 -g -Wall -W -I$(CURDIR) +CFLAGS ?= -O2 -g -Wall -Wextra -I$(CURDIR) LDFLAGS += -lpci -lz
SRCS = viatool.c \
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34455 )
Change subject: util/*/Makefile: Rename -W to -Wextra ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34455 )
Change subject: util/*/Makefile: Rename -W to -Wextra ......................................................................
util/*/Makefile: Rename -W to -Wextra
-W is the old name for -Wextra, so let's rename it to be consistent with the rest of the utility Makefiles.
Change-Id: I0e50f13d2617b785d343707fc895516574164562 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/34455 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M util/ectool/Makefile M util/ifdtool/Makefile M util/intelmetool/Makefile M util/inteltool/Makefile M util/nvramtool/Makefile M util/pmh7tool/Makefile M util/viatool/Makefile 7 files changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/util/ectool/Makefile b/util/ectool/Makefile index c4b94da..fdda265 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -15,7 +15,7 @@ ##
CC = gcc -CFLAGS = -O2 -Wall -W +CFLAGS = -O2 -Wall -Wextra PROGRAM = ectool INSTALL = /usr/bin/env install PREFIX = /usr/local diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index 4cddfc5..cc52b1e 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -18,7 +18,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -Werror -I../../src/commonlib/include +CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror -I../../src/commonlib/include LDFLAGS =
OBJS = ifdtool.o diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile index 45a87c7..55ba82a 100644 --- a/util/intelmetool/Makefile +++ b/util/intelmetool/Makefile @@ -17,7 +17,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O0 -g -Wall -W -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function +CFLAGS ?= -O0 -g -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function LDFLAGS += -lpci -lz
OBJS = intelmetool.o me.o me_status.o mmap.o rcba.o msr.o diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index 0f74a7c..cd02fa8 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -22,7 +22,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O2 -g -Wall -W -Wmissing-prototypes +CFLAGS ?= -O2 -g -Wall -Wextra -Wmissing-prototypes LDFLAGS += -lpci -lz
CPPFLAGS += -I$(top)/src/commonlib/include diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 46297a2..c210234 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -19,7 +19,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -I. -DCMOS_HAL=1 +CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall
CLI_OBJS = cli/nvramtool.o cli/opts.o diff --git a/util/pmh7tool/Makefile b/util/pmh7tool/Makefile index 384d3d9..034ed40 100644 --- a/util/pmh7tool/Makefile +++ b/util/pmh7tool/Makefile @@ -14,7 +14,7 @@ ##
CC = gcc -CFLAGS = -O2 -Wall -W -Werror +CFLAGS = -O2 -Wall -Wextra -Werror PROGRAM = pmh7tool INSTALL = /usr/bin/env install PREFIX = /usr/local diff --git a/util/viatool/Makefile b/util/viatool/Makefile index b2a6291..f58cbd3 100644 --- a/util/viatool/Makefile +++ b/util/viatool/Makefile @@ -21,7 +21,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O2 -g -Wall -W -I$(CURDIR) +CFLAGS ?= -O2 -g -Wall -Wextra -I$(CURDIR) LDFLAGS += -lpci -lz
SRCS = viatool.c \
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)