Attention is currently required from: Nico Huber, Peter Lemenkov, Alexander Couzens, Patrick Rudolph, amersel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541 ......................................................................
Patch Set 16: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/05ad75d4_9f94ad17 PS16, Line 37: - libgfxinit Have you tried selecting ONBOARD_VGA_IS_PRIMARY? Maybe coreboot prefers the dGPU over the iGPU.
DisplayPort on the dock is multiplexed with the dGPU. It may need special handling. GPIO19 controls the multiplexors: High => iGPU, Low => dGPU.
(added later) Eh, gma-mainboard.ads has a more serious issue.
File src/mainboard/lenovo/w541/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52659/comment/7e321489_8c1c3578 PS16, Line 40: register "sata_port_map" = "0x33" Still spaces
File src/mainboard/lenovo/w541/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/52659/comment/64bdd192_2783aefa PS16, Line 13: eDP eDP is unused on this board, this should be DP3 instead.
# Explanation
On Haswell/LynxPoint, eDP and FDI (used for VGA output through the PCH) share two lanes. One can either run eDP with 4 lanes, or eDP and FDI with 2 lanes each.
The LCD on this laptop uses 4 lanes, though. And it also uses the VGA output through the PCH. To handle this, the board designers used a regular DP DDI (Digital Display Interface) to connect the eDP panel to. The eDP pins are not connected.
-
Angel Pons (Code Review)