Change in coreboot[master]: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support
Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38517 )
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support
Jasperlake rvp external ec board can use chromeos-ec, so adding config option to select chromeos ec and TPM (when board also supports TPM2)
BUG=NONE BRANCH=None TEST=Jasperlake RVP and Jasperlake ext ec board builds fine
Change-Id: I0ca74f0beb7b31ba4b1915ef21773a4a1b4327b3 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/chromeos.c 2 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/38517/1
diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index 97b038e..5660e52 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -31,6 +31,28 @@ string default "Intel_jasperlake_rvp"
+config JSL_EXTERNAL_EC + bool "JSL External EC" + default y if BOARD_INTEL_JASPERLAKE_RVP_EXT_EC + default n + select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_LPC + select EC_GOOGLE_CHROMEEC_SWITCHES + +config JSL_INTEL_EC + bool "Internal EC" + default y if BOARD_INTEL_JASPERLAKE_RVP + default n + select MAINBOARD_USES_IFD_EC_REGION + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + +config JSL_HAS_TPM + bool "JSL TPM2 support" + default y if BOARD_INTEL_JASPERLAKE_RVP_EXT_EC + default n + select MAINBOARD_HAS_SPI_TPM_CR50 + select MAINBOARD_HAS_TPM2 + config MAX_CPUS int default 8 @@ -44,8 +66,8 @@ default 512
config VBOOT - select VBOOT_LID_SWITCH - select VBOOT_MOCK_SECDATA + select VBOOT_LID_SWITCH if !EC_GOOGLE_CHROMEEC_SWITCHES + select VBOOT_MOCK_SECDATA if !JSL_HAS_TPM
config UART_FOR_CONSOLE int diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.c b/src/mainboard/intel/jasperlake_rvp/chromeos.c index 372f6ce..4b589f0 100644 --- a/src/mainboard/intel/jasperlake_rvp/chromeos.c +++ b/src/mainboard/intel/jasperlake_rvp/chromeos.c @@ -30,6 +30,7 @@ lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); }
+#if !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) int get_lid_switch(void) { /* Lid always open */ @@ -40,6 +41,7 @@ { return 0; } +#endif
int get_write_protect_state(void) {
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38517 )
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38517/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38517/1/src/mainboard/intel/jasperl... PS1, Line 33: #if !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38517
to look at the new patch set (#2).
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support
Jasperlake rvp external ec board can use chromeos-ec, so adding config option to select chromeos ec and TPM (when board also supports TPM2)
BUG=NONE BRANCH=None TEST=Jasperlake RVP and Jasperlake ext ec board builds fine
Change-Id: I0ca74f0beb7b31ba4b1915ef21773a4a1b4327b3 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/chromeos.c 2 files changed, 26 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/38517/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38517 )
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38517/2/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38517/2/src/mainboard/intel/jasperl... PS2, Line 33: #if !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38517
to look at the new patch set (#3).
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support
Jasperlake rvp external ec board can use chromeos-ec, so adding config option to select chromeos ec and TPM (when board also supports TPM2)
BUG=NONE BRANCH=None TEST=Jasperlake RVP and Jasperlake ext ec board builds fine
Change-Id: I0ca74f0beb7b31ba4b1915ef21773a4a1b4327b3 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/chromeos.c 2 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/38517/3
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38517 )
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... PS3, Line 37: select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_LPC : select EC_GOOGLE_CHROMEEC_SWITCHES We can select these configs under BOARD_INTEL_JASPERLAKE_RVP_EXT_EC in Kconfig.name. So we don't need this config item. Same for JSL_INTEL_EC and JSL_HAS_TPM.
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38517/3/src/mainboard/intel/jasperl... PS3, Line 46: #endif Add a comment after endif /* !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) */
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38517?usp=email )
Change subject: mb/intel/jasperlake_rvp: Add proper Kconfig for chrome ec support ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Stefan Reinauer (Code Review)