Attention is currently required from: Hung-Te Lin, Liu Liu, Vince Liu, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87021?usp=email )
Change subject: soc/mediatek/mt8189: Add usb host support
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/mt8189/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/87021/comment/abcd8dd8_332c9465?usp... :
PS1, Line 35: SSUSB_SIF_BASE = IO_PHYS + 0x01B00300,
Please note in the commit message, why these values were changed.
File src/soc/mediatek/mt8189/include/soc/usb.h:
https://review.coreboot.org/c/coreboot/+/87021/comment/03c1e764_150a9fcd?usp... :
PS1, Line 22: check_member(ssusb_sif_port, u3phyd, 0x600);
: check_member(ssusb_sif_port, u3phya, 0x800);
: check_member(ssusb_sif_port, u3phya_da, 0x900);
: check_member(ssusb_sif_port, reserved2, 0xa00);
Should macros be defined for the values?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87021?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f1b4b3eb178cb9a110b97a2763c8cff5cdf0ddd
Gerrit-Change-Number: 87021
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Liu Liu
ot_liu.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Liu Liu
ot_liu.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 28 Mar 2025 08:32:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No