Change in coreboot[master]: src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table gene...

[Michał Żygowski (Code Review)]

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35286 )

Change subject: src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table generation
......................................................................

src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table generation

The MCFG ACPI table was not being created.

Signed-off-by: Michał Żygowski 
Change-Id: I35bdefb2a565d18917a2f6517d443890f93bd252
---
M src/southbridge/amd/pi/hudson/lpc.c
1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/35286/1

diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c
index 5354a27..02123a1 100644
--- a/src/southbridge/amd/pi/hudson/lpc.c
+++ b/src/southbridge/amd/pi/hudson/lpc.c
@@ -332,7 +332,11 @@

unsigned long acpi_fill_mcfg(unsigned long current)
 {
-	/* Just a dummy */
+	current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,
+					     CONFIG_MMCONF_BASE_ADDRESS,
+					     0,
+					     0,
+					     CONFIG_MMCONF_BUS_NUMBER);
    return current;
 }

[Michał Żygowski (Code Review)]

Michał Żygowski has removed Patrick Rudolph from this change.  ( https://review.coreboot.org/c/coreboot/+/35286 )

Change subject: src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table generation
......................................................................

Removed reviewer Patrick Rudolph.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35286 )

Change subject: src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table generation
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35286 )

Change subject: src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table generation
......................................................................

src/southbridge/amd/pi/hudson/lpc.c: add missing MCFG ACPI table generation

The MCFG ACPI table was not being created.

Signed-off-by: Michał Żygowski 
Change-Id: I35bdefb2a565d18917a2f6517d443890f93bd252
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35286
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/southbridge/amd/pi/hudson/lpc.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c
index 5354a27..02123a1 100644
--- a/src/southbridge/amd/pi/hudson/lpc.c
+++ b/src/southbridge/amd/pi/hudson/lpc.c
@@ -332,7 +332,11 @@

unsigned long acpi_fill_mcfg(unsigned long current)
 {
-	/* Just a dummy */
+	current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,
+					     CONFIG_MMCONF_BASE_ADDRESS,
+					     0,
+					     0,
+					     CONFIG_MMCONF_BUS_NUMBER);
    return current;
 }