Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48495 )
Change subject: mb/google/volteer: Update drobit device tree ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48495/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/drobit/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48495/1/src/mainboard/google/voltee... PS1, Line 23: recommend you add the `common_soc_config` section here too, e.g.: ``` register "common_soc_config" = "{ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .gspi[0] = { .speed_mhz = 1, .early_init = 1, }, .i2c[0] = { .speed = I2C_SPEED_FAST, }, .i2c[1] = { .speed = I2C_SPEED_FAST, }, .i2c[5] = { .speed = I2C_SPEED_FAST, }, } ```
https://review.coreboot.org/c/coreboot/+/48495/1/src/mainboard/google/voltee... PS1, Line 136: ELAN2701 Just checking, Delbin uses `ELAN0000` here, is this a different controller?