Change in coreboot[master]: soc/amd/common/espi,mb/: Allow configuring open drain ALERT# - coreboot-gerrit

5 May 2021


      Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Rob Barnes, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52954 )
Change subject: soc/amd/common/espi,mb/: Allow configuring open drain ALERT#
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/52954/comment/ec60a78e_3fc0abd4 
PS2, Line 690: 	case ESPI_ALERT_PIN_IN_BAND:
...
For readability: slave_config |= ESPI_SLAVE_ALERT_MODE_IO1
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia35fc59a699cf9444b53aad5c9bb71aa27ce9251
Gerrit-Change-Number: 52954
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 05 May 2021 20:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Gerrit-MessageType: comment