Attention is currently required from: Maximilian Brune, Angel Pons, Lean Sheng Tan, David Milosevic.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
......................................................................
Patch Set 11:
(3 comments)
File src/mainboard/prodrive/atlas/emi.c:
https://review.coreboot.org/c/coreboot/+/68137/comment/93ff04fd_c3cec9c6
PS11, Line 59: u8 bytes[4] = { 0 };
use u32.
https://review.coreboot.org/c/coreboot/+/68137/comment/3c671c14_f1cc4aba
PS11, Line 71: buff[idx++] = bytes[i];
Use memcpy
https://review.coreboot.org/c/coreboot/+/68137/comment/c9277ce1_746e5b72
PS11, Line 68: if (idx == n)
: return;
:
: buff[idx++]
Can you put those conditions in the for loop? That makes it easier to read.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391
Gerrit-Change-Number: 68137
Gerrit-PatchSet: 11
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 16:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment