Change in ...coreboot[master]: soc/intel/bsw: Move memory init values into `romstage.h`

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32592 )

Change subject: soc/intel/bsw: Move memory init values into `romstage.h`
......................................................................

soc/intel/bsw: Move memory init values into `romstage.h`

`chip.h` is usually used as devicetree interface.

Change-Id: Ied30927d68927b86758a84ccf3f5fbd8cce632f1
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32592
Reviewed-by: Patrick Georgi 
Reviewed-by: Matt DeVillier 
Reviewed-by: Frans Hendriks 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/cyan/romstage.c
M src/mainboard/intel/strago/romstage.c
M src/soc/intel/braswell/chip.h
M src/soc/intel/braswell/include/soc/romstage.h
4 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Matt DeVillier: Looks good to me, but someone else must approve
  Frans Hendriks: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/cyan/romstage.c b/src/mainboard/google/cyan/romstage.c
index aa20593..5470b9c 100644
--- a/src/mainboard/google/cyan/romstage.c
+++ b/src/mainboard/google/cyan/romstage.c
@@ -16,7 +16,6 @@

#include <soc/romstage.h>
 #include <baseboard/variants.h>
-#include <chip.h>

/* All FSP specific code goes in this block */
 void mainboard_romstage_entry(struct romstage_params *rp)
diff --git a/src/mainboard/intel/strago/romstage.c b/src/mainboard/intel/strago/romstage.c
index 0f3067e..ba0ff7b 100644
--- a/src/mainboard/intel/strago/romstage.c
+++ b/src/mainboard/intel/strago/romstage.c
@@ -17,7 +17,6 @@
 #include <soc/gpio.h>
 #include <soc/pci_devs.h>
 #include <soc/romstage.h>
-#include <chip.h>
 #include "onboard.h"
 #include <boardid.h>

diff --git a/src/soc/intel/braswell/chip.h b/src/soc/intel/braswell/chip.h
index bb06dd5..5a00328 100644
--- a/src/soc/intel/braswell/chip.h
+++ b/src/soc/intel/braswell/chip.h
@@ -32,9 +32,6 @@
 #define SVID_CONFIG3		3
 #define SVID_PMIC_CONFIG	8

-#define MEM_DDR3	0
-#define MEM_LPDDR3	1
-
 enum lpe_clk_src {
    LPE_CLK_SRC_XTAL,
    LPE_CLK_SRC_PLL,
diff --git a/src/soc/intel/braswell/include/soc/romstage.h b/src/soc/intel/braswell/include/soc/romstage.h
index 8fa9c8a..2512430 100644
--- a/src/soc/intel/braswell/include/soc/romstage.h
+++ b/src/soc/intel/braswell/include/soc/romstage.h
@@ -34,4 +34,8 @@
 void program_base_addresses(void);
 int chipset_prev_sleep_state(struct chipset_power_state *ps);

+/* Values for FSP's PcdMemoryTypeEnable */
+#define MEM_DDR3	0
+#define MEM_LPDDR3	1
+
 #endif /* _SOC_ROMSTAGE_H_ */