Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44882 )
Change subject: security/intel/txt: Add missing definitions ......................................................................
security/intel/txt: Add missing definitions
Change-Id: I3ca585429df318c31c2ffd484ec91a7971f18f27 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/security/intel/txt/txt_register.h 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/44882/1
diff --git a/src/security/intel/txt/txt_register.h b/src/security/intel/txt/txt_register.h index 70bb309..688221f 100644 --- a/src/security/intel/txt/txt_register.h +++ b/src/security/intel/txt/txt_register.h @@ -121,6 +121,7 @@ #define TXT_RESERVED_SPACE_SIZE 0x3ffff
/* ESI flags for GETSEC[ENTERACCS] see Reference Number: 323372-017 */ +#define ACMINPUT_SCLEAN 0 #define ACMINPUT_RESET_TPM_AUXILIARY_INDICIES 2 #define ACMINPUT_NOP 3 #define ACMINPUT_SCHECK 4 @@ -231,6 +232,13 @@ #define HEAP_EXTDATA_TYPE_ACM 2 #define HEAP_EXTDATA_TYPE_CUSTOM 4
+struct __packed txt_bios_spec_ver_element { + struct txt_extended_data_element_header header; + uint16_t ver_major; + uint16_t ver_minor; + uint16_t ver_revision; +}; + struct __packed txt_heap_acm_element { struct txt_extended_data_element_header header; uint32_t num_acms; // must greater 0, smaller than 3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44882 )
Change subject: security/intel/txt: Add missing definitions ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44882 )
Change subject: security/intel/txt: Add missing definitions ......................................................................
Patch Set 2: Code-Review+1
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44882 )
Change subject: security/intel/txt: Add missing definitions ......................................................................
security/intel/txt: Add missing definitions
Change-Id: I3ca585429df318c31c2ffd484ec91a7971f18f27 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44882 Reviewed-by: Michael Niewöhner Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/intel/txt/txt_register.h 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/src/security/intel/txt/txt_register.h b/src/security/intel/txt/txt_register.h index 70bb309..688221f 100644 --- a/src/security/intel/txt/txt_register.h +++ b/src/security/intel/txt/txt_register.h @@ -121,6 +121,7 @@ #define TXT_RESERVED_SPACE_SIZE 0x3ffff
/* ESI flags for GETSEC[ENTERACCS] see Reference Number: 323372-017 */ +#define ACMINPUT_SCLEAN 0 #define ACMINPUT_RESET_TPM_AUXILIARY_INDICIES 2 #define ACMINPUT_NOP 3 #define ACMINPUT_SCHECK 4 @@ -231,6 +232,13 @@ #define HEAP_EXTDATA_TYPE_ACM 2 #define HEAP_EXTDATA_TYPE_CUSTOM 4
+struct __packed txt_bios_spec_ver_element { + struct txt_extended_data_element_header header; + uint16_t ver_major; + uint16_t ver_minor; + uint16_t ver_revision; +}; + struct __packed txt_heap_acm_element { struct txt_extended_data_element_header header; uint32_t num_acms; // must greater 0, smaller than 3
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Patrick Rudolph (Code Review)