Change in coreboot[master]: mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48123 )

Change subject: mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS
......................................................................

mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS

Remove JSL specific SMBIOS sku id info as it is not required by
EHL.

Signed-off-by: Tan, Lean Sheng 
Change-Id: Ib672eb456ba62f2eb7f941630c4fbb34823664f5
---
M src/mainboard/intel/elkhartlake_crb/mainboard.c
1 file changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48123/1

diff --git a/src/mainboard/intel/elkhartlake_crb/mainboard.c b/src/mainboard/intel/elkhartlake_crb/mainboard.c
index f529573..c63beb7 100644
--- a/src/mainboard/intel/elkhartlake_crb/mainboard.c
+++ b/src/mainboard/intel/elkhartlake_crb/mainboard.c
@@ -3,7 +3,6 @@
 #include <baseboard/variants.h>
 #include <device/device.h>
 #include <soc/gpio.h>
-#include <smbios.h>

static void mainboard_init(void *chip_info)
 {
@@ -14,12 +13,6 @@
    gpio_configure_pads(pads, num);
 }

-const char *smbios_system_sku(void)
-{
-	static const char *sku_str = "sku2147483647"; /* sku{0-1} */
-	return sku_str;
-}
-
 struct chip_operations mainboard_ops = {
    .init = mainboard_init,
 };

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48123 )

Change subject: mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS
......................................................................

Patch Set 1: Code-Review+2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48123 )

Change subject: mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS
......................................................................

Patch Set 2: Code-Review+2

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48123 )

Change subject: mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS
......................................................................

mb/intel/ehlcrb: Remove JSL sku id info in SMBIOS

Remove JSL specific SMBIOS sku id info as it is not required by
EHL.

Signed-off-by: Tan, Lean Sheng 
Change-Id: Ib672eb456ba62f2eb7f941630c4fbb34823664f5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48123
Reviewed-by: Frans Hendriks 
Reviewed-by: Werner Zeh 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/intel/elkhartlake_crb/mainboard.c
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Werner Zeh: Looks good to me, approved
  Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/intel/elkhartlake_crb/mainboard.c b/src/mainboard/intel/elkhartlake_crb/mainboard.c
index f529573..c63beb7 100644
--- a/src/mainboard/intel/elkhartlake_crb/mainboard.c
+++ b/src/mainboard/intel/elkhartlake_crb/mainboard.c
@@ -3,7 +3,6 @@
 #include <baseboard/variants.h>
 #include <device/device.h>
 #include <soc/gpio.h>
-#include <smbios.h>

static void mainboard_init(void *chip_info)
 {
@@ -14,12 +13,6 @@
    gpio_configure_pads(pads, num);
 }

-const char *smbios_system_sku(void)
-{
-	static const char *sku_str = "sku2147483647"; /* sku{0-1} */
-	return sku_str;
-}
-
 struct chip_operations mainboard_ops = {
    .init = mainboard_init,
 };