Attention is currently required from: Felix Singer, Subrata Banik, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56217 )
Change subject: mb/intel/coffeelake_rvp: Rework Kconfig ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56217/comment/d230b701_2896810a PS3, Line 17: Built each variant with `BUILD_TIMELESS=1` and all generated I imagine you had to skip including the config file inside the coreboot.rom, otherwise it would have changed.
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56217/comment/a1271f1f_d0b95d5a PS3, Line 1: BOARD_INTEL_COFFEELAKE_COMMON BOARD_INTEL_COFFEELAKE_RVP_COMMON
https://review.coreboot.org/c/coreboot/+/56217/comment/9a946e63_7fc31957 PS3, Line 15: BOARD_INTEL_COFFEELAKE_RVP8_OPTIONS I'd reuse the symbols declared in Kconfig.name
-
Angel Pons (Code Review)