Attention is currently required from: Felix Held.
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69814 )
Change subject: src/superio: Remove unnecessary space after casts ......................................................................
src/superio: Remove unnecessary space after casts
Change-Id: Iab76316f345fb0cf2ca2a3eaf40f64a1f1b7fc13 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/superio/aspeed/common/aspeed.h M src/superio/fintek/f81803a/fan_control.c 2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/69814/1
diff --git a/src/superio/aspeed/common/aspeed.h b/src/superio/aspeed/common/aspeed.h index 3673a71..f41ca0f 100644 --- a/src/superio/aspeed/common/aspeed.h +++ b/src/superio/aspeed/common/aspeed.h @@ -408,7 +408,7 @@ #define ASPEED_EXIT_KEY 0xAA
#define TO_BE_UPDATE 0 -#define AndMask32(HighBit, LowBit) ~((((uint32_t) 1 << (HighBit - LowBit + 1)) - 1) << LowBit) +#define AndMask32(HighBit, LowBit) ~((((uint32_t)1 << (HighBit - LowBit + 1)) - 1) << LowBit)
typedef enum { GPIOA = 0, diff --git a/src/superio/fintek/f81803a/fan_control.c b/src/superio/fintek/f81803a/fan_control.c index 06a8338..8b5ddac 100644 --- a/src/superio/fintek/f81803a/fan_control.c +++ b/src/superio/fintek/f81803a/fan_control.c @@ -281,7 +281,7 @@ if (value > 100) return message_invalid_2(HWM_STATUS_INVALID_SECTION_VALUE, fan); temp = (255 * value) / 100; - value = (u8) (temp & 0x00ff); + value = (u8)(temp & 0x00ff); write_hwm_reg(base_address, index, value); index++; }