Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
mb/google/kukui: Add new configs 'esche' and 'burnet'
new boards introduced to Kukui family.
BUG=b:161768221 BRANCH=master TEST=emerge-jacuzzi coreboot
Change-Id: I2245c34533549bb94c58938fee5778b8a03e2767 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43667/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index f390147..f583f95 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -29,7 +29,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI - select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN || BOARD_GOOGLE_WILLOW + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN || BOARD_GOOGLE_WILLOWa || BOARD_GOOGLE_ESCHE || BOARD_GOOGLE_BURNET select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE
config MAINBOARD_DIR @@ -50,6 +50,8 @@ default "Cerise" if BOARD_GOOGLE_CERISE default "Stern" if BOARD_GOOGLE_STERN default "Willow" if BOARD_GOOGLE_WILLOW + default "Esche" if BOARD_GOOGLE_ESCHE + default "Burnet" if BOARD_GOOGLE_BURNET
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 55e0101..ee60d3f 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -47,3 +47,11 @@ config BOARD_GOOGLE_WILLOW bool "-> Willow" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_ESCHE + bool "-> Esche" + select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_BURNET + bool "-> Burnet" + select BOARD_GOOGLE_KUKUI_COMMON
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43667
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
mb/google/kukui: Add new configs 'esche' and 'burnet'
new boards introduced to Kukui family. esche: clamshell burnet: 360 convertible
BUG=b:161768221 BRANCH=master TEST=emerge-jacuzzi coreboot
Change-Id: I2245c34533549bb94c58938fee5778b8a03e2767 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43667/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... PS3, Line 59: BOARD_GOOGLE_KUKUI_COMMON should this be kukui or jacuzzi?
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... PS3, Line 59: BOARD_GOOGLE_KUKUI_COMMON
should this be kukui or jacuzzi?
Hi Hung-Te, burnet is 360 convertible, so from your Cl here (https://review.coreboot.org/c/coreboot/+/43436/13) 360 convertible belongs to "clamshell/BOARD_GOOGLE_JACUZZI_COMMON", right?
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... PS3, Line 59: BOARD_GOOGLE_KUKUI_COMMON
Hi Hung-Te, […]
Right, but here you named it KUKUI_COMMON
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... PS3, Line 59: BOARD_GOOGLE_KUKUI_COMMON
Right, but here you named it KUKUI_COMMON
yes, it was set to "BOARD_GOOGLE_JACUZZI_COMMON" originally until I read CL:43436 and think 360 convertible might belong to "detachable and tablets/BOARD_GOOGLE_KUKUI_COMMON" scope. I'll update to correct it, thanks.
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43667
to look at the new patch set (#4).
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
mb/google/kukui: Add new configs 'esche' and 'burnet'
new boards introduced to Kukui family. esche: clamshell burnet: 360 convertible
BUG=b:161768221 BRANCH=master TEST=emerge-jacuzzi coreboot
Change-Id: I2245c34533549bb94c58938fee5778b8a03e2767 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43667/4
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 4: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/43667/3/src/mainboard/google/kukui/... PS3, Line 59: BOARD_GOOGLE_KUKUI_COMMON
yes, it was set to "BOARD_GOOGLE_JACUZZI_COMMON" originally until I read CL:43436 and think 360 conv […]
Ack
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 4:
Hi Hung-Te, thank you for the review, could you please also help merge this one?
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 4:
thank you for the review, could you please also help merge this one?
Usually we will submit after the change gets +2 for 24 hours. Please stay tuned.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
Patch Set 4:
Patch Set 4:
thank you for the review, could you please also help merge this one?
Usually we will submit after the change gets +2 for 24 hours. Please stay tuned.
noted, thanks.
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43667 )
Change subject: mb/google/kukui: Add new configs 'esche' and 'burnet' ......................................................................
mb/google/kukui: Add new configs 'esche' and 'burnet'
new boards introduced to Kukui family. esche: clamshell burnet: 360 convertible
BUG=b:161768221 BRANCH=master TEST=emerge-jacuzzi coreboot
Change-Id: I2245c34533549bb94c58938fee5778b8a03e2767 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43667 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 59bcaf2..906dfea 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -55,6 +55,8 @@ default "Cerise" if BOARD_GOOGLE_CERISE default "Stern" if BOARD_GOOGLE_STERN default "Willow" if BOARD_GOOGLE_WILLOW + default "Esche" if BOARD_GOOGLE_ESCHE + default "Burnet" if BOARD_GOOGLE_BURNET
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index d84e77c..77cdc67 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -49,3 +49,11 @@ config BOARD_GOOGLE_WILLOW bool "-> Willow" select BOARD_GOOGLE_JACUZZI_COMMON + +config BOARD_GOOGLE_ESCHE + bool "-> Esche" + select BOARD_GOOGLE_JACUZZI_COMMON + +config BOARD_GOOGLE_BURNET + bool "-> Burnet" + select BOARD_GOOGLE_JACUZZI_COMMON
-
Hung-Te Lin (Code Review) -
Kevin Chiu (Code Review)