EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix ......................................................................
mb/google/drallion: Turn off HDMI power when enter s0ix
Turn off HDMI power when enter s0ix.
BUG=b:143057255 BRANCH=N/A TEST=Measure the power on GPP_E16 under s0ix
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I580e6094d48663d5c208fd82c7744485d899bcc1 --- M src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36224/1
diff --git a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl index 41121d2..544aaa0 100644 --- a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl @@ -15,6 +15,7 @@
#define CAM_EN GPP_B11 /* Active low */ #define TS_PD GPP_E7 +#define HDMI_PD GPP_E16
/* Method called from LPIT prior to enter s0ix state */ Method (MS0X, 1) @@ -22,9 +23,13 @@ If (Arg0) { /* Turn off camera power */ _SB.PCI0.STXS (CAM_EN) + /* Turn off HDMI power */ + _SB.PCI0.CTXS (HDMI_PD) } Else { /* Turn on camera power */ _SB.PCI0.CTXS (CAM_EN) + /* Turn on HDMI power */ + _SB.PCI0.STXS (HDMI_PD) } }
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
Patch Set 3:
This change is ready for review.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
Patch Set 3: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
Patch Set 3:
@Bora, could you work with Tim to find why E16 will leakage 1v after we turn off to 0V. I think that is not related to this patch. You can check the issue for some detail.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
Patch Set 3: Code-Review-1
Just hold on for HW clear the 1V issue.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
Patch Set 3:
Patch Set 3:
@Bora, could you work with Tim to find why E16 will leakage 1v after we turn off to 0V. I think that is not related to this patch. You can check the issue for some detail.
Sure, I will work with him.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
Patch Set 3: -Code-Review
Since E16 signal is clear at Intel side. we can merge this.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36224 )
Change subject: mb/google/drallion: Turn off HDMI power when enter s0ix and S5 ......................................................................
mb/google/drallion: Turn off HDMI power when enter s0ix and S5
Turn off HDMI power when enter s0ix and S5.
BUG=b:143057255 BRANCH=N/A TEST=Measure the power on GPP_E16 under s0ix and S5
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I580e6094d48663d5c208fd82c7744485d899bcc1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36224 Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl index 41121d2..dbe487e 100644 --- a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl @@ -15,6 +15,7 @@
#define CAM_EN GPP_B11 /* Active low */ #define TS_PD GPP_E7 +#define HDMI_PD GPP_E16
/* Method called from LPIT prior to enter s0ix state */ Method (MS0X, 1) @@ -22,9 +23,13 @@ If (Arg0) { /* Turn off camera power */ _SB.PCI0.STXS (CAM_EN) + /* Turn off HDMI power */ + _SB.PCI0.CTXS (HDMI_PD) } Else { /* Turn on camera power */ _SB.PCI0.CTXS (CAM_EN) + /* Turn on HDMI power */ + _SB.PCI0.STXS (HDMI_PD) } }
@@ -35,6 +40,8 @@
/* Clear touch screen pd pin to avoid leakage */ _SB.PCI0.CTXS (TS_PD) + /* Clear HDMI power to avoid leakage */ + _SB.PCI0.CTXS (HDMI_PD) }
/* Method called from _WAK prior to wakeup */
-
Bora Guvendik (Code Review) -
EricR Lai (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)