Attention is currently required from: Arthur Heymans, Jason Glenesk, Marshall Dawson, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59130 )
Change subject: soc/amd/common/block/lpc: Set FSP-S/M alignment to 64 when using SPI DMA
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/lpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/59130/comment/088cad8d_70c826db
PS1, Line 24:
: config FSP_ALIGNMENT_FSP_S
: int
: default 64 if SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA
:
: config FSP_ALIGNMENT_FSP_M
: int
: default 64 if SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA
cbfs always has a 64 byte alignment. […]
The metadata does, the actual payload doesn't though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I282b9989d8e95c93603c6f69616a8f236a4e2e35
Gerrit-Change-Number: 59130
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 Nov 2021 21:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-MessageType: comment