Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Subrata Banik, Raj Astekar, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51723 )
Change subject: *x86: Support x2apic mode
......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51723/comment/7f15ac20_45c77529
PS6, Line 10: LAPIC_BASE_MSR(LAPIC_BASE_MSR_X2APIC_MODE)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/51723/comment/6f994713_5f9b9a65
PS6, Line 11: implment
implement
https://review.coreboot.org/c/coreboot/+/51723/comment/2d7bb4c3_ec2a6638
PS6, Line 21: cat /proc/cpuinfo | grep "apicid"
No need to use cat. ;-)
grep apicid /proc/cpuinfo
Patchset:
PS5:
Why are there three +2, if a 500 line change does not have a commit message consisting of one line?
*does only have a commit message body consisting of one line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bb729b0521fb9dc38b7981014755daeaf9ca817
Gerrit-Change-Number: 51723
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 02 Apr 2021 07:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment