Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52729 )
Change subject: lib/coreboot_table.c: Remove unnecessary CPP use ......................................................................
lib/coreboot_table.c: Remove unnecessary CPP use
Change-Id: Ib93617867b946e208c31275d55d380aab7e51a50 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/52729 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/lib/coreboot_table.c 1 file changed, 5 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index cb85a18..9264efb 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -466,12 +466,11 @@ lb_mainboard(head);
/* Record the serial ports and consoles */ -#if CONFIG(CONSOLE_SERIAL) - uart_fill_lb(head); -#endif -#if CONFIG(CONSOLE_USB) - lb_add_console(LB_TAG_CONSOLE_EHCI, head); -#endif + if (CONFIG(CONSOLE_SERIAL)) + uart_fill_lb(head); + + if (CONFIG(CONSOLE_USB)) + lb_add_console(LB_TAG_CONSOLE_EHCI, head);
/* Record our various random string information */ lb_strings(head);