Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
lib/coreboot_table.c: Remove unnecessary CPP use

Change-Id: Ib93617867b946e208c31275d55d380aab7e51a50
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52729
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/lib/coreboot_table.c
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index cb85a18..9264efb 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -466,12 +466,11 @@
lb_mainboard(head);

/* Record the serial ports and consoles */
-#if CONFIG(CONSOLE_SERIAL)
- uart_fill_lb(head);
-#endif
-#if CONFIG(CONSOLE_USB)
- lb_add_console(LB_TAG_CONSOLE_EHCI, head);
-#endif
+ if (CONFIG(CONSOLE_SERIAL))
+ uart_fill_lb(head);
+
+ if (CONFIG(CONSOLE_USB))
+ lb_add_console(LB_TAG_CONSOLE_EHCI, head);

/* Record our various random string information */
lb_strings(head);

To view, visit change 52729. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib93617867b946e208c31275d55d380aab7e51a50
Gerrit-Change-Number: 52729
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged