Change in coreboot[master]: AGESA: Fix discovery of IO APICs number

List overview All Threads
Download

newer

older

Change in coreboot[master]: src:...

Change in coreboot[master]:...

Krystian Hebel (Code Review)

26 Jul 2019 26 Jul '19

5:07 p.m.

Krystian Hebel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

AGESA: Fix discovery of IO APICs number

Number of IO APICs are hardcoded. This fix reads this number from the default values obtained by creating a structure for a parameter block of an AGESA.

While it is possible to modify NumberOfIoApics in callouts, every platform currently in the tree goes with the default value.

Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 --- M src/drivers/amd/agesa/state_machine.c M src/northbridge/amd/agesa/agesa_helper.h M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c 4 files changed, 21 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34589/1

diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index 750d192..7964f4e 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -297,6 +297,23 @@ return (final < AGESA_FATAL) ? 0 : -1; }

+int amd_get_ioapic_num(void) { + AMD_INTERFACE_PARAMS aip; + AMD_EARLY_PARAMS *params; + int ret; + + agesa_locate_image(&aip.StdHeader); + + amd_create_struct(&aip, AMD_INIT_EARLY, NULL, 0); + + params = (AMD_EARLY_PARAMS *)aip.NewStructPtr; + ret = params->PlatformConfig.NumberOfIoApics; + + amd_release_struct(&aip); + + return ret; +} + #if ENV_RAMSTAGE

static void amd_bs_ramstage_init(void *arg) diff --git a/src/northbridge/amd/agesa/agesa_helper.h b/src/northbridge/amd/agesa/agesa_helper.h index 17819e9..97eba2f 100644 --- a/src/northbridge/amd/agesa/agesa_helper.h +++ b/src/northbridge/amd/agesa/agesa_helper.h @@ -39,6 +39,8 @@ void amd_initmmio(void); void amd_initenv(void);

+int amd_get_ioapic_num(void); + void *GetHeapBase(void); void EmptyHeap(void);

diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index c6457a3..e9a1e05 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -870,7 +870,7 @@ * for their APIC id and therefore must reside at 0..15 */

- u8 plat_num_io_apics = 3; /* FIXME */ + u8 plat_num_io_apics = amd_get_ioapic_num();

if ((node_nums * core_max) + plat_num_io_apics >= 0x10) { lapicid_start = (plat_num_io_apics - 1) / core_max; diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 928d9d2..b3b68f9 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -896,7 +896,7 @@ * for their APIC id and therefore must reside at 0..15 */

- u8 plat_num_io_apics = 3; /* FIXME */ + u8 plat_num_io_apics = amd_get_ioapic_num();

if ((node_nums * core_max) + plat_num_io_apics >= 0x10) { lapicid_start = (plat_num_io_apics - 1) / core_max;

Attachments:

attachment.htm (text/html — 6.1 KB)

Show replies by thread

build bot (Jenkins) (Code Review)

26 Jul 26 Jul

5:07 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34589/1/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:

https://review.coreboot.org/c/coreboot/+/34589/1/src/drivers/amd/agesa/state... PS1, Line 300: int amd_get_ioapic_num(void) { open brace '{' following function definitions go on the next line

Krystian Hebel (Code Review)

5:11 p.m.

Krystian Hebel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

AGESA: Fix discovery of IO APICs number

Number of IO APICs are hardcoded. This fix reads this number from the default values obtained by creating a structure for a parameter block of an AGESA.

While it is possible to modify NumberOfIoApics in callouts, every platform currently in the tree goes with the default value.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34589/2

Paul Menzel (Code Review)

2 Oct 2 Oct

2:46 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

Tested how? Does it increase size or boot time?

https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG@9 PS2, Line 9: are is

https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG@10 PS2, Line 10: parameter : block of an AGESA What is that?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 2 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Wed, 02 Oct 2019 12:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michał Żygowski (Code Review)

4 Oct 4 Oct

12:34 p.m.

Michał Żygowski has uploaded a new patch set (#3) to the change originally created by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

AGESA: Fix discovery of IO APICs number

Number of IO APICs is hardcoded. This fix reads this number from the default values obtained by interfacing AGESA and accessing its parameter block.

While it is possible to modify NumberOfIoApics in callouts, every platform currently in the tree goes with the default value.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34589/3

Michał Żygowski (Code Review)

12:39 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 3:

(2 comments)

Tested with booting PC Engines APU2 on top of the postcar stage patches in the relation chain.

It neither improves boot time nor size. Just removes the hardcoded value which is not elegant by reading the value from silicon initialization code.

https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG@9 PS2, Line 9: are

...

is

Done

https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG@10 PS2, Line 10: parameter : block of an AGESA

...

What is that?

Rephrased it a little bit. In short, we interface AMD proprietary initialization blob called AGESA which holds the configuration values for the processor/SoC used in initialization process inside the blob.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 3 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Fri, 04 Oct 2019 10:39:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Michał Żygowski (Code Review)

17 Nov 17 Nov

10:46 p.m.

Michał Żygowski has uploaded a new patch set (#4) to the change originally created by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

AGESA: Fix discovery of IO APICs number

Number of IO APICs are hardcoded. This fix reads this number from the default values obtained by creating a structure for a parameter block of an AGESA.

While it is possible to modify NumberOfIoApics in callouts, every platform currently in the tree goes with the default value.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34589/4

build bot (Jenkins) (Code Review)

10:48 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:

https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... PS4, Line 297: int amd_get_ioapic_num(void) { open brace '{' following function definitions go on the next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 4 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Sun, 17 Nov 2019 21:48:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

19 Nov 19 Nov

1:08 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 4: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:

https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... PS4, Line 297: int amd_get_ioapic_num(void) {

...

open brace '{' following function definitions go on the next line

This should be addressed.

https://review.coreboot.org/c/coreboot/+/34589/4/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34589/4/src/northbridge/amd/agesa/f... PS4, Line 873: u8 plat_num_io_apics = amd_get_ioapic_num(); Nit: maybe this can be made const

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 4 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Tue, 19 Nov 2019 12:08:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Krystian Hebel (Code Review)

6:03 p.m.

Hello Kyösti Mälkki, Angel Pons, Paul Menzel, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34589

to look at the new patch set (#5).

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

AGESA: Fix discovery of IO APICs number

Number of IO APICs are hardcoded. This fix reads this number from the default values obtained by creating a structure for a parameter block of an AGESA.

While it is possible to modify NumberOfIoApics in callouts, every platform currently in the tree goes with the default value.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34589/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 5 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

20 Nov 20 Nov

7:30 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 5 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Wed, 20 Nov 2019 18:30:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:33 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 5: -Code-Review

(2 comments)

oops, the commit message reverted to the patchset 2 state (while it was much better in ps #3)

https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:

https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... PS4, Line 297: int amd_get_ioapic_num(void) {

...

This should be addressed.

Done

https://review.coreboot.org/c/coreboot/+/34589/4/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34589/4/src/northbridge/amd/agesa/f... PS4, Line 873: u8 plat_num_io_apics = amd_get_ioapic_num();

...

Nit: maybe this can be made const

Ack, but it was a non-const constant before, so... ;-)

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 5 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Wed, 20 Nov 2019 18:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

23 Nov 23 Nov

6:30 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 5: Code-Review-2

(1 comment)

Not urgent for POSTCAR_STAGE=y fix, postponed.

https://review.coreboot.org/c/coreboot/+/34589/5/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:

https://review.coreboot.org/c/coreboot/+/34589/5/src/drivers/amd/agesa/state... PS5, Line 305: amd_create_struct(&aip, AMD_INIT_EARLY, NULL, 0); We don't link AMD_INIT_EARLY to ramstage at all in vendorcode. vendorcode/amd/agesa/common/agesa-entry-cfg.h

It is there in the PI blob though, but we will not open up the can of worms of having multiple callsites with AMD_CREATE_STRUCT and same *params.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 5 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Sat, 23 Nov 2019 17:30:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michał Żygowski (Code Review)

18 Dec 18 Dec

12:35 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Patch Set 5:

Krystian, could you abandon this change please? We decided to go for Kconfig option in CB:37169

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 5 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Wed, 18 Dec 2019 11:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krystian Hebel (Code Review)

12:47 p.m.

Krystian Hebel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34589 )

Change subject: AGESA: Fix discovery of IO APICs number ......................................................................

Abandoned

We decided to go for Kconfig option in CB:37169

-- To view, visit https://review.coreboot.org/c/coreboot/+/34589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664 Gerrit-Change-Number: 34589 Gerrit-PatchSet: 5 Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: abandon

1601

days inactive

1746

days old

coreboot-gerrit@coreboot.org

14 comments

7 participants

tags (0)

participants (7)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Krystian Hebel (Code Review)
Kyösti Mälkki (Code Review)
Michał Żygowski (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)