Nico Huber has posted comments on this change. ( https://review.coreboot.org/20887 )
Change subject: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/20887/1/src/mainboard/lenovo/x1_carbon_gen1/...
File src/mainboard/lenovo/x1_carbon_gen1/romstage.c:
https://review.coreboot.org/#/c/20887/1/src/mainboard/lenovo/x1_carbon_gen1/...
PS1, Line 111: We only support elpida
comment needs to be updated.
thanks, done
--
To view, visit
https://review.coreboot.org/20887
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189
Gerrit-Change-Number: 20887
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 05 Aug 2017 22:23:34 +0000
Gerrit-HasComments: Yes