Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60129 )
Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed ......................................................................
libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
The probe should output the 'INFO' instead of 'ERROR' when the i8042 module can't be probed. For the x86 device, which enables the PC_I8042 by default, the 'ERROR' message will be outputted if the device doesn't connect to an i8042 keyboard controller. This is an unexpected error when doing the autotest.
BUG=b:207077409 TEST=`test_that f:.*power_Resume/control` pass
Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Signed-off-by: Zhuohao Lee zhuohao@chromium.org --- M payloads/libpayload/drivers/i8042/i8042.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60129/1
diff --git a/payloads/libpayload/drivers/i8042/i8042.c b/payloads/libpayload/drivers/i8042/i8042.c index a89b9d9..052f9e8 100644 --- a/payloads/libpayload/drivers/i8042/i8042.c +++ b/payloads/libpayload/drivers/i8042/i8042.c @@ -211,7 +211,7 @@ /* If 0x64 returns 0xff, then we have no keyboard * controller */ if (read_status() == 0xFF) { - printf("ERROR: No keyboard controller found!\n"); + printf("INFO: No keyboard controller found!\n"); return 0; }