Attention is currently required from: Kyösti Mälkki, Sean Rhodes.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77882?usp=email )
Change subject: include/commonlib/coreboot_tables: Add CFR structs
......................................................................
Patch Set 5:
(1 comment)
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/77882/comment/485cc4cb_428392df :
PS4, Line 29: * choose. All strings are in ASCII.
Some characters possibly need escaping or are prohibited? […]
EDK2 doesn't complain about tabs or newlines.
newline is honoured. Tabs are removed.
I'd say payload should take care of "special" characters if needed. Either render them or remove them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77882?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44f006318a15556f97da286dc032c58ccb7993e4
Gerrit-Change-Number: 77882
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 27 Sep 2023 11:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment