Change in coreboot[master]: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A)
Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43801 )
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A) ......................................................................
mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A)
Select the drivers for ALC5682 codec and MX98360A spk amp
BUG=b:161407664 BRANCH=NONE TEST=FW_NAME=madoo emerge-dedede coreboot chromeos-bootimage
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ibe3d878b1058bfae4143d96be854884e61394ad5 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 20 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/43801/1
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index c793866..754c306 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -59,13 +59,26 @@ device pci 15.0 on end device pci 15.2 on end device pci 1c.7 on end - device pci 19.0 on end - device pci 1f.3 on - chip drivers/generic/max98357a - register "hid" = ""MX98360A"" + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Headset Codec"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + end #I2C 4 + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98360A"" register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" - device generic 0 on end - end - end # Intel HDA + device generic 0 on end + end + end # Intel HDA end end
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43801 )
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43801/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43801/1/src/mainboard/google/dedede... PS1, Line 77: chip drivers/generic/max98357a Please fix the indent
Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Henry Sun, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43801
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A) ......................................................................
mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A)
Select the drivers for ALC5682 codec and MX98360A spk amp
BUG=b:161407664 BRANCH=NONE TEST=FW_NAME=madoo emerge-dedede coreboot chromeos-bootimage
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ibe3d878b1058bfae4143d96be854884e61394ad5 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 20 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/43801/2
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43801 )
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A) ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43801/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43801/1/src/mainboard/google/dedede... PS1, Line 77: chip drivers/generic/max98357a
Please fix the indent
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43801 )
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A) ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43801 )
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A) ......................................................................
mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A)
Select the drivers for ALC5682 codec and MX98360A spk amp
BUG=b:161407664 BRANCH=NONE TEST=FW_NAME=madoo emerge-dedede coreboot chromeos-bootimage
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ibe3d878b1058bfae4143d96be854884e61394ad5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43801 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 20 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index c793866..e189ec3 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -59,13 +59,26 @@ device pci 15.0 on end device pci 15.2 on end device pci 1c.7 on end - device pci 19.0 on end - device pci 1f.3 on - chip drivers/generic/max98357a - register "hid" = ""MX98360A"" + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Headset Codec"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + end #I2C 4 + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98360A"" register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" - device generic 0 on end - end - end # Intel HDA + device generic 0 on end + end + end # Intel HDA end end
-
Dtrain Hsu (Code Review) -
EricR Lai (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)