Attention is currently required from: Bao Zheng, Jason Glenesk, Martin Roth, Marshall Dawson, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49855 )
Change subject: soc/amd: Throw an error if ROM size is invalid ......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49855/comment/c44b7ed2_7311fdac PS5, Line 44: $(if $(CONFIG_AMD_FWM_POSITION_INDEX), , the code was correct before, but the error message was missing the main issue that needs to be fixed in the corresponding board code. If the boards sets a valid board rom size, then the soc's Kconfig file will select a default for CONFIG_AMD_FWM_POSITION_INDEX, so if there's no default set for CONFIG_AMD_FWM_POSITION_INDEX, the cause of that is the board not having selected a valid rom size. majolica and guybrush override the default, since they have different special cases; one is having the flash shared with an EC and the other is having multiple CBFS in different FMAP partitions whenere the read-only one is the last one in flash. If a board neither shares the flash with an EC nor uses vboot, the board has no need to set CONFIG_AMD_FWM_POSITION_INDEX by itself and just provide a valid rom size
-
Felix Held (Code Review)