Attention is currently required from: Angel Pons.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50789 )
Change subject: device/azalia: Switch to stopwatch
......................................................................
Patch Set 2:
(2 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/50789/comment/7c5d855a_4884b6b5
PS2, Line 178: udelay(1);
This timeout isn't done anymore, do we need it?
The CFL FSP doesn't have this delay.
https://review.coreboot.org/c/coreboot/+/50789/comment/6c0be61d_d9afd7c9
PS2, Line 174: stopwatch_init_usecs_expire(&sw, 50);
CFL FSP uses 10msec for iGPU here and 1msec for regular HDA codecs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1227c6812618597c37408a7bf53bcbcae97374a
Gerrit-Change-Number: 50789
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 24 Feb 2021 11:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment