Change in coreboot[master]: util/amdfwtool: Fix all warnings - coreboot-gerrit

18 Feb 2021


      Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50643 )
Change subject: util/amdfwtool: Fix all warnings
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
...
I'll take a look at bilby and either push a fix or revert.  Thanks for the notification.
i just verified that his can't have caused any breakage the embedded team was seeing; even with the mp2 and s0i3 firmware added to a build i get the exact same binary when doing timeless builds. so it wasn't this patch that broke it
PS2: 
cc
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I761d9893ac6737b42af96c4b2a57c5a4fc61ab05
Gerrit-Change-Number: 50643
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ritul guru ritul.bits@gmail.com
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Feb 2021 17:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment