Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56173 )
Change subject: soc/intel/common/irq: Account for single-function devices ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
not required […]
Correct, just PCI_INT_A
File src/soc/intel/common/block/irq/irq.c:
https://review.coreboot.org/c/coreboot/+/56173/comment/ada6f267_6bb42e0e PS1, Line 257: IRQ_NONE
Should this be `!= IRQ_NONE` or `== IRQ_PIRQ`? What happens if there are multiple functions but only […]
this is wrong anyway
https://review.coreboot.org/c/coreboot/+/56173/comment/527cef35_02ed10b6 PS1, Line 266: /* Single-function devices must use PIRQ_A */
BTW, is the requirement that the single-function device must use PIRQ_A? Or is it that it must use I […]
haha, looks like I misread my own notes (double checked in the BWG, it is INTA, not PIRQ_A). Which basically means this was unnecessary, `find_free_pin()` will always start with PCI_INT_A, so you would have to construct a slot so as to violate this constraint (fixed pins B,C,D only, no PIRQs, no DIRECT either).
tl;dr this change can be dropped.
-
Tim Wawrzynczak (Code Review)