Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32049
Change subject: soc/apl: Add eMMC and Sdcard config options ......................................................................
soc/apl: Add eMMC and Sdcard config options
Change-Id: I5e7df076d1e76358de5a899a3a44e8ca864882ba Signed-off-by: Felix Singer felix.singer@9elements.com --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32049/1
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 30a537b..3a405af 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -741,6 +741,9 @@ /* Disable FSP from locking access to the RTC NVRAM */ silconfig->RtcLock = 0;
+ silconfig->eMMCEnabled = cfg->emmc_enabled; + silconfig->SdcardEnabled = cfg->sdcard_enabled; + /* Enable Audio clk gate and power gate */ silconfig->HDAudioClkGate = cfg->hdaudio_clk_gate_enable; silconfig->HDAudioPwrGate = cfg->hdaudio_pwr_gate_enable; diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index b9e368c..a995f2d 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -120,6 +120,9 @@ /* PL2 override value in mW for APL */ uint16_t tdp_pl2_override_mw;
+ uint8_t emmc_enabled; + uint8_t sdcard_enabled; + /* Configure Audio clk gate and power gate * IOSF-SB port ID 92 offset 0x530 [5] and [3] */
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32049 )
Change subject: soc/apl: Add eMMC, SD-Card and SDIO config options ......................................................................
Patch Set 3:
This change is ready for review.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32049 )
Change subject: soc/apl: Add eMMC, SD-Card and SDIO config options ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@713 PS3, Line 713: silconfig->eMMCEnabled = cfg->emmc_enabled; already set by parse_devicetree()
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@729 PS3, Line 729: silconfig->SdcardEnabled = cfg->sdcard_enabled; already set by parse_devicetree()
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@743 PS3, Line 743: silconfig->SdioEnabled = cfg->sdio_enabled; already set by parse_devicetree()
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@771 PS3, Line 771: unrelated
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32049
to look at the new patch set (#4).
Change subject: soc/apl: Add eMMC, SD-Card and SDIO config options ......................................................................
soc/apl: Add eMMC, SD-Card and SDIO config options
FSP-S options: - SdcardTxCmdCntl - SdcardTxDataCntl1 - SdcardTxDataCntl2 - SdcardRxCmdDataCntl1 - SdcardRxStrobeCntl - SdcardRxCmdDataCntl2 - SdioTxCmdCntl - SdioTxDataCntl1 - SdioTxDataCntl2 - SdioRxCmdDataCntl1 - SdioRxCmdDataCntl2
Change-Id: I5e7df076d1e76358de5a899a3a44e8ca864882ba Signed-off-by: Felix Singer felix.singer@9elements.com --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 2 files changed, 37 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32049/4
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32049 )
Change subject: soc/apl: Add eMMC, SD-Card and SDIO config options ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@713 PS3, Line 713: silconfig->eMMCEnabled = cfg->emmc_enabled;
already set by parse_devicetree()
Removed, but I thought about surrounding the eMMC option block by 'if (silconfig->eMMC_enabled)', but the code would be more unreadable because of the 80 chars limit and line breaks.
What do you think?
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@729 PS3, Line 729: silconfig->SdcardEnabled = cfg->sdcard_enabled;
already set by parse_devicetree()
Same.
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@743 PS3, Line 743: silconfig->SdioEnabled = cfg->sdio_enabled;
already set by parse_devicetree()
Same.
https://review.coreboot.org/#/c/32049/3/src/soc/intel/apollolake/chip.c@771 PS3, Line 771:
unrelated
Done
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32049 )
Change subject: soc/apl: Add eMMC, SD-Card and SDIO config options ......................................................................
Abandoned
-
Felix Singer (Code Review) -
Patrick Rudolph (Code Review)