Attention is currently required from: Jan Tatje, Nico Huber, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 )
Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
I agree to the `SkipExtGfxScan` change now. But it would be nice to
move the `SkipExtGfxScan = 0` setting to the override tree that also
enables the IGD. (Actually, I'd prefer the IGD to be always enabled
or have a Kconfig for it. It's not board specific, hence doesn't belong
in the devicetree.)
I'd rather enable IGD in the board devicetree (the one changed in this change) and have `PrimaryDisplay=Display_PEG` here, too. Also I disagree with having `SkipExtGfxScan = 0` written explicitly and just drop the option (0 is default anyway).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce
Gerrit-Change-Number: 56071
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Tatje
jan@jnt.io
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jan Tatje
jan@jnt.io
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 10 Jul 2021 17:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Tatje
jan@jnt.io
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment