Attention is currently required from: Tarun Tuli, Subrata Banik, Nick Vaccaro, Angel Pons, Martin Roth.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67933 )
Change subject: device/xhci: Factor out common PORTSC code
......................................................................
Patch Set 7:
(4 comments)
File src/include/device/xhci.h:
https://review.coreboot.org/c/coreboot/+/67933/comment/0ec23280_beaeef36
PS5, Line 17: (1 << 26)
can you use BIT(26) instead
Done
https://review.coreboot.org/c/coreboot/+/67933/comment/4dfb56f0_f37473b4
PS5, Line 25: (5)
u don't need braces
Done
https://review.coreboot.org/c/coreboot/+/67933/comment/fba23d4a_cdd989bb
PS5, Line 26: 0xF
use small case?
Done
https://review.coreboot.org/c/coreboot/+/67933/comment/ae56645e_74aa251c
PS5, Line 36: !!
Nit: Shouldn't be needed for bool.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I045405ed224aa8f48f6f628b7d49ec6bafb450d7
Gerrit-Change-Number: 67933
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 23:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment