Attention is currently required from: Julius Werner, Raul Rangel.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82687?usp=email )
Change subject: libpayload: Include libpayload-config.h in lib target
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/82687/comment/9499e7e0_34b03721?usp... :
PS1, Line 118: $(obj)/libpayload.ldscript: arch/$(ARCHDIR-y)/libpayload.ldscript
I think you still need to declare `$(obj)/libpayload-config.h` as a dependency here. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If26336f6261aadf611fa5338c4300873156cc3da
Gerrit-Change-Number: 82687
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 28 May 2024 18:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com