[XS] Change in coreboot[main]: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS

[Matt DeVillier (Code Review)]

Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Karthik Ramasubramanian, Yu-Ping Wu.

Matt DeVillier has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83495?usp=email )

Change subject: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS
......................................................................

Patch Set 8: Code-Review+1

(1 comment)

File src/soc/amd/common/vboot/vbnv_cmos.c:

https://review.coreboot.org/c/coreboot/+/83495/comment/de1dd5e5_d33c0877?usp... :
PS7, Line 8: /* Select Bank 0 to allow writing to VBNV. */
from the comment, one might infer that the value `0` passed to `cmos_init()` is for bank selection, but it's not. A comment similar to the one found in the call to `cmos_init()` in `src/soc/amd/common/block/lpc/lpc.c` might be appropriate here