Change in coreboot[master]: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36594 )

Change subject: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK
......................................................................

bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK

Change-Id: I5617e5d9b7238ad7a894934910a3eae742d2d22d
Signed-off-by: Kyösti Mälkki 
---
M src/lib/bootblock.c
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/36594/1

diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c
index 19841c6..4f5d887 100644
--- a/src/lib/bootblock.c
+++ b/src/lib/bootblock.c
@@ -41,6 +41,8 @@
 static void bootblock_main_with_timestamp(uint64_t base_timestamp,
    struct timestamp_entry *timestamps, size_t num_timestamps)
 {
+	uint64_t ts_start = timestamp_get();
+
    /* Initialize timestamps if we have TIMESTAMP region in memlayout.ld. */
    if (CONFIG(COLLECT_TIMESTAMPS) &&
        REGION_SIZE(timestamp) > 0) {
@@ -51,6 +53,8 @@
    			      timestamps[i].entry_stamp);
    }

+	timestamp_add(TS_START_BOOTBLOCK, ts_start);
+
    bootblock_soc_early_init();
    bootblock_mainboard_early_init();

@@ -65,6 +69,8 @@
    bootblock_soc_init();
    bootblock_mainboard_init();

+	timestamp_add_now(TS_END_BOOTBLOCK);
+
    run_romstage();
 }

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36594

to look at the new patch set (#2).

Change subject: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK
......................................................................

bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK

Change-Id: I5617e5d9b7238ad7a894934910a3eae742d2d22d
Signed-off-by: Kyösti Mälkki 
---
M src/lib/bootblock.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/36594/2

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36594 )

Change subject: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/36594/2/src/lib/bootblock.c 
File src/lib/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36594/2/src/lib/bootblock.c@54 
PS2, Line 54: TS_START_BOOTBLOCK
It's weird that those exist, without being used...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36594 )

Change subject: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36594/2/src/lib/bootblock.c 
File src/lib/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36594/2/src/lib/bootblock.c@54 
PS2, Line 54: TS_START_BOOTBLOCK
> It's weird that those exist, without being used...

ok

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36594 )

Change subject: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK
......................................................................

Patch Set 3: Code-Review+1

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36594 )

Change subject: bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK
......................................................................

bootblock: Add TS_START_BOOTBLOCK and TS_END_BOOTBLOCK

Change-Id: I5617e5d9b7238ad7a894934910a3eae742d2d22d
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36594
Reviewed-by: Paul Menzel 
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/lib/bootblock.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Arthur Heymans: Looks good to me, approved

diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c
index 19841c6..5fb6067 100644
--- a/src/lib/bootblock.c
+++ b/src/lib/bootblock.c
@@ -51,6 +51,8 @@
    			      timestamps[i].entry_stamp);
    }

+	timestamp_add_now(TS_START_BOOTBLOCK);
+
    bootblock_soc_early_init();
    bootblock_mainboard_early_init();

@@ -65,6 +67,8 @@
    bootblock_soc_init();
    bootblock_mainboard_init();

+	timestamp_add_now(TS_END_BOOTBLOCK);
+
    run_romstage();
 }