Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/...
File src/mainboard/acer/es1-572/romstage.c:
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/...
PS4, Line 25: static void mainboard_fill_dq_map_data(void *dq_map_ch0, void *dq_map_ch1)
I'll check, I'm not sure.
Gone. This is for LPDDR only.
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/...
PS4, Line 37: static void mainboard_fill_dqs_map_data(void *dqs_map_ch0, void *dqs_map_ch1)
Same here.
Gone. This is for LPDDR only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38978
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id98788a2c5e54f70fd1cacbd70d636f5e63b2619
Gerrit-Change-Number: 38978
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Sat, 14 Mar 2020 21:44:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment