Attention is currently required from: Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56617 )
Change subject: soc/intel/{adl,cnl,ehl,icl,jsl,tgl}: Clear RTC_BATTERY_DEAD
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/56617/comment/d93d8540_75cd3747
PS1, Line 188: soc_get_rtc_failed
`soc_get_rtc_failed()` gets called only in ramstage. So, clearing `RTC_BATTERY_DEAD` here wouldn't really fix the boot loop you mentioned in commit message.
If you decide to move this to `vbnv_cmos_failed()` you will have to ensure that the cmos_init() flow still looks correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc21c19ea8ce561e9655e189ec26aba7a07967e
Gerrit-Change-Number: 56617
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 27 Jul 2021 22:18:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment