Change in coreboot[master]: soc/intel/common: gpio: print error if pad is not found

[Maxim Polyakov (Code Review)]

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40021 )

Change subject: soc/intel/common: gpio: print error if pad is not found
......................................................................

soc/intel/common: gpio: print error if pad is not found

Allow to print a debug error message when the GPIO community does not
contain the pad number from the motherboard configuration.

Change-Id: I21fb389a5d29e11b1fbc24e836d91e17957047f1
Signed-off-by: Maxim Polyakov 
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/40021/1

diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c
index 45406db..dedd364 100644
--- a/src/soc/intel/common/block/gpio/gpio.c
+++ b/src/soc/intel/common/block/gpio/gpio.c
@@ -89,7 +89,8 @@
    		return i;
    	}
    }
-
+	printk(BIOS_ERR, "%s: pad %d is not found in community %s!\n",
+			__func__, relative_pad, comm->name);
    assert(0);

return i;

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40021 )

Change subject: soc/intel/common: gpio: print error if pad is not found
......................................................................

Patch Set 1: Code-Review+2

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40021 )

Change subject: soc/intel/common: gpio: print error if pad is not found
......................................................................

Patch Set 1:

I run the test on my Tioga Pass, the boot error log is below:
gpio_pad_reset_config_override: Logical to Chipset mapping not found
gpio_group_index: pad 0 is not found in community GPIO_COM5!
ASSERTION ERROR: file 'src/soc/intel/common/block/gpio/gpio.c', line 94

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40021 )

Change subject: soc/intel/common: gpio: print error if pad is not found
......................................................................

Patch Set 3:
> Patch Set 1:
>
> I run the test on my Tioga Pass, the boot error log is below:
> gpio_pad_reset_config_override: Logical to Chipset mapping not found
> gpio_group_index: pad 0 is not found in community GPIO_COM5!
> ASSERTION ERROR: file 'src/soc/intel/common/block/gpio/gpio.c', line 94

Hi Johnny! Thank you for testing. I found a error in gpio comm5 in my code and already fixed it:
https://review.coreboot.org/c/coreboot/+/39425/15..16

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Andrey Petrov, David Hendricks, Angel Pons, Andrey Petrov, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40021

to look at the new patch set (#8).

Change subject: soc/intel/common: gpio: print error if pad is not found
......................................................................

soc/intel/common: gpio: print error if pad is not found

Allow to print a debug error message when the GPIO community does not
contain the pad number from the motherboard configuration.

Change-Id: I21fb389a5d29e11b1fbc24e836d91e17957047f1
Signed-off-by: Maxim Polyakov 
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/40021/8

[Andrey Petrov (Code Review)]

Andrey Petrov has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40021 )

Change subject: soc/intel/common: gpio: print error if pad is not found
......................................................................

soc/intel/common: gpio: print error if pad is not found

Allow to print a debug error message when the GPIO community does not
contain the pad number from the motherboard configuration.

Change-Id: I21fb389a5d29e11b1fbc24e836d91e17957047f1
Signed-off-by: Maxim Polyakov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40021
Tested-by: build bot (Jenkins) 
Reviewed-by: Andrey Petrov 
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Andrey Petrov: Looks good to me, approved

diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c
index 45406db..dedd364 100644
--- a/src/soc/intel/common/block/gpio/gpio.c
+++ b/src/soc/intel/common/block/gpio/gpio.c
@@ -89,7 +89,8 @@
    		return i;
    	}
    }
-
+	printk(BIOS_ERR, "%s: pad %d is not found in community %s!\n",
+			__func__, relative_pad, comm->name);
    assert(0);

return i;