Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 )
Change subject: mb/google/deltaur: add deltaur mainboard initial support
......................................................................
Patch Set 5:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Should we create deltaue in variants as well? Or just let it in baseboard? I think it is different variants.
The plan is to add deltaur once we have the GPIO config. for the moment we focus on Deltan
LGTM.
I ended up adding deltaur in variants to make buildbot happy. Let me know if it looks ok.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98f328df22f39e7d9d625a3292954881ee15b15
Gerrit-Change-Number: 39502
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Mar 2020 22:54:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment