[S] Change in coreboot[main]: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR

[John Su (Code Review)]

Attention is currently required from: Ben Kao, Dinesh Gehlot, Dtrain Hsu, Eric Lai, Intel coreboot Reviewers, Jamie Chen, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik.

John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87033?usp=email )

Change subject: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR
......................................................................

Patch Set 8:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/87033/comment/afe7e5e7_439136d4?usp... :
PS6, Line 9: R(
> nit: space

Done

https://review.coreboot.org/c/coreboot/+/87033/comment/97dc1be0_32d27863?usp... :
PS6, Line 10: (
> nit: space

Done

File src/mainboard/google/brya/variants/uldrenite/variant.c:

https://review.coreboot.org/c/coreboot/+/87033/comment/f9e77185_6fd55276?usp... :
PS6, Line 3: #include <baseboard/gpio.h>
           : #include <baseboard/variants.h>
           : #include <console/console.h>
           : #include <delay.h>
           : #include <fw_config.h>
           : #include <sar.h>
           : #include <soc/bootblock.h>
           : #include <boardid.h>
> nit: Not a strong rule, but usually headers are alphabetically sorted. […]

Done

https://review.coreboot.org/c/coreboot/+/87033/comment/75550145_3f09199d?usp... :
PS6, Line 85: .*
> space

Done

https://review.coreboot.org/c/coreboot/+/87033/comment/13a5a6eb_657f0d4b?usp... :
PS6, Line 91: }
> space

Done

https://review.coreboot.org/c/coreboot/+/87033/comment/f15da16a_bf6c52d2?usp... :
PS6, Line 96: }
> space

Done

https://review.coreboot.org/c/coreboot/+/87033/comment/58b3817d_13547131?usp... :
PS6, Line 96: 0xc33,  0x72}
> Any specification to reference?

Follow Intel Client SPI Programming Guide.

File src/soc/intel/alderlake/bootblock/update_descriptor.c:

https://review.coreboot.org/c/coreboot/+/87033/comment/a50158b2_0f4b564a?usp... :
PS6, Line 26: if (read32p((uintptr_t)(desc + FLASH_SIGN_OFFSET)) != FLASH_VAL_SIGN) {
            : 		printk(BIOS_ERR, "Flash Descriptor is not valid\n");
            : 		return false;
            : 	}
            : 
            : 	/* Check host has write access to the Descriptor Region */
            : 	if (!((read32p((uintptr_t)(desc + FLMSTR1)) >> FLMSTR_WR_SHIFT_V2) & BIT(0))) {
            : 		printk(BIOS_ERR, "Host doesn't have write access to Descriptor Region\n");
            : 		return false;
            : 	}
> Why is this necessary?

The builder encounters an error due to a type mismatch issue, so a forced conversion is applied.