Attention is currently required from: Pratikkumar Prajapati.
Hello Pratikkumar Prajapati,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/77237?usp=email
to review the following change.
Change subject: soc/intel/common: Make common cpu_cl_clear_data() weak ......................................................................
soc/intel/common: Make common cpu_cl_clear_data() weak
Not all SOC follow the same programming to clear crashlog data. So make common implementation of cpu_cl_clear_data() weak.
BUG=b:262501347 TEST=Able to build REX.
Change-Id: Ic2b4631d57703abff0ab1880fb272ef67bb1b8e9 Signed-off-by: Pratikkumar Prajapati pratikkumar.v.prajapati@intel.corp-partner.google.com --- M src/soc/intel/common/block/crashlog/crashlog.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/77237/1
diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index fa36033..4412cbb 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -149,7 +149,7 @@ return 1; }
-int cpu_cl_clear_data(void) +int __weak cpu_cl_clear_data(void) { return cpu_cl_mailbox_cmd(CPU_CRASHLOG_CMD_CLEAR, 0); }