Attention is currently required from: Felix Singer, Nico Huber, Martin Roth, Angel Pons, Julius Werner.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56410 )
Change subject: kconfig_lint: Drop overly restrictive rules about choice configs
......................................................................
Patch Set 6:
(1 comment)
File util/lint/kconfig_lint:
https://review.coreboot.org/c/coreboot/+/56410/comment/b7160cc9_e8f84919
PS2, Line 817: elsif ( $inside_choice && $symbols{$symbol}{choice} ) {
: show_error( "$symbol entry at $filename:$line_no has already been created inside another choice block "
: . "at $symbols{$symbol}{0}{file}:$symbols{$symbol}{0}{line_no}." );
: }
:
This one is not being dropped in the latest PS, however, it's still too restrictive:
The message says "another choice block" but this "another" is never checked, AFAICS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48a17f6403470251be6b6d44bb82a8bdcbefe9f6
Gerrit-Change-Number: 56410
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sun, 17 Oct 2021 13:48:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment