build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29697 )
Change subject: soc/intel/icelake: Create macros for FSP consumption as per ICL requirement
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29697/1/src/soc/intel/icelake/include/soc/se...
File src/soc/intel/icelake/include/soc/serialio.h:
https://review.coreboot.org/#/c/29697/1/src/soc/intel/icelake/include/soc/se...
PS1, Line 25: } PCH_SERIAL_IO_MODE;
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e4bc304f93e4b63ac2d7f194ca441dd96dd943
Gerrit-Change-Number: 29697
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 20 Nov 2018 11:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment