Attention is currently required from: Nico Huber, Kyösti Mälkki, Felix Held.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52927 )
Change subject: nb/amd/pi/00730F01/northbridge.c: Report missing resources
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52927/comment/6c0d5ed5_bc5c7b6a
PS3, Line 256: * 0xc0000 - 0xcffff: VGA OPROM
is it intended that the d segment isn't listed here?
Rather not. It should be included in the SeaBIOS range, as D segment is mainly used by oproms
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52927
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia57ab026218f4aae0a98c2081412c4a9ebb7f57a
Gerrit-Change-Number: 52927
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 May 2021 18:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment