Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email )
Change subject: mb/google/rauru: Enable firmware display ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85952/comment/1056d57d_0e656a55?usp... : PS3, Line 9: mt8196 rauru
https://review.coreboot.org/c/coreboot/+/85952/comment/7d518c2a_1565b77f?usp... : PS3, Line 9: Enable mt8196 firmware display support.
What needs to be done to enable the display?
Please explain what `mt6373_set_vcn33_3_voltage` is for in the commit message.
https://review.coreboot.org/c/coreboot/+/85952/comment/5429a4b4_3808be17?usp... : PS3, Line 11: TEST=Build pass, the firmware screen displays correctly.
In a normal boot, it’s skipped, and the Linux kernel initializes the display, correct?
Correct.
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85952/comment/657c36c5_2c1ed8cd?usp... : PS3, Line 107: else Add {}