Change in coreboot[master]: sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34436 )
Change subject: sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST ......................................................................
sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST
Change-Id: I82d696ec79cb8a182e6b35de70c0e1ede2fa0bd9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/fsp_rangeley/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/34436/1
diff --git a/src/southbridge/intel/fsp_rangeley/romstage.c b/src/southbridge/intel/fsp_rangeley/romstage.c index 2c2427e..297e1c4 100644 --- a/src/southbridge/intel/fsp_rangeley/romstage.c +++ b/src/southbridge/intel/fsp_rangeley/romstage.c @@ -43,7 +43,7 @@ * This causes the I/O to clog and a side effect is * that the reset button stops functioning. So * instead just use outb so it doesn't output to the - * console when CONFIG_CONSOLE_POST. + * console when CONFIG(CONSOLE_POST). */ outb(0x40, 0x80);
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34436 )
Change subject: sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST ......................................................................
Patch Set 1: Code-Review+1
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34436 )
Change subject: sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34436 )
Change subject: sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST ......................................................................
Patch Set 1:
Julius, I guess this is what you meant with "flaky" in CB:31777. How do you think we should handle these cases?
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34436 )
Change subject: sb/intel/fsp_rangeley: Fix naked reference to CONFIG_CONSOLE_POST ......................................................................
Abandoned
see https://review.coreboot.org/c/coreboot/+/36980
-
Christian Walter (Code Review) -
David Guckian (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)