Attention is currently required from: Jason Glenesk, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58991 )
Change subject: soc/amd/cezanne/fsp: Set the void_function parameter
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/fsp_s_params.c:
https://review.coreboot.org/c/coreboot/+/58991/comment/29edf0b5_719d75d7
PS3, Line 24: scfg->void_function = (uintptr_t)fsp_s_yield;
What happens if FSP re-inits any of the IP blocks that coreboot is trying to leverage at this point? […]
I know for a fact that FSP will re-init the UART. This doesn't cause a problem since it's a very simple controller. Since FSP is huge, I'm not sure what else it is initializing. I haven't seen a problem though...
I think FSP sets up its own exception handlers as well. I haven't actually tried to force an exception in this callback though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02818987a574f14f790d34f4f0af6b993c520727
Gerrit-Change-Number: 58991
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 22 Nov 2021 19:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment