Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom - coreboot-gerrit

7 Jan 2022


      Attention is currently required from: Sam McNally, Felix Singer, Ricardo Quesada, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 )
Change subject: util/cbfstool: Port elogtool to libflashrom
......................................................................
Patch Set 14:
(1 comment)
File util/cbfstool/uflashrom.c:
https://review.coreboot.org/c/coreboot/+/59714/comment/824f3853_5c6d7c96 
PS10, Line 145: 		r |= flashrom_layout_include_region(layout, region);
...
You are correct, the API is a rock and hard place. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231
Gerrit-Change-Number: 59714
Gerrit-PatchSet: 14
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen roccochen@google.com
Gerrit-Reviewer: Jack Rosenthal jrosenth@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Ricardo Quesada ricardoq@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Ricardo Quesada ricardoq@google.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Fri, 07 Jan 2022 10:42:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally sammc@google.com
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment