Change in coreboot[master]: mb/google/dedede/var/sasuke: Configure GPP_G7 as native - coreboot-gerrit

22 Jan 2021


      Attention is currently required from: Jamie Chen, shkim, Henry Sun, Karthik Ramasubramanian.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49791 )
Change subject: mb/google/dedede/var/sasuke: Configure GPP_G7 as native
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/sasuke/gpio.c:
https://review.coreboot.org/c/coreboot/+/49791/comment/032f4470_24aa6199 
PS2, Line 52: 	PAD_NC(GPP_G7, NONE),
...
Looking at the schematics, this GPIO is not connected to anything. […]
Let's see the intel's response in the tracker. Anyway this change affects the SD card function obviously due to the test result.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If73337b482f04fd263caaa6fed0e54aa87bd876e
Gerrit-Change-Number: 49791
Gerrit-PatchSet: 2
Gerrit-Owner: shkim sh_.kim@samsung.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Jamie Chen jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jamie Chen jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: shkim sh_.kim@samsung.com
Gerrit-Attention: Henry Sun henrysun@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 01:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment