Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email )
Change subject: vendorcode/amd: Hook up opensil ......................................................................
Patch Set 15: Code-Review+2
(3 comments)
Patchset:
PS15: I noted a couple of minor issues - let's fix these in a follow-on commit.
Marking everyone else's changes as +2 - Do not merge until there's another +2 for my changes please.
File src/vendorcode/amd/opensil/Kconfig:
https://review.coreboot.org/c/coreboot/+/76511/comment/3a74d483_b65caa79 : PS14, Line 8: sil Nit: capitalize - openSIL
File src/vendorcode/amd/opensil/genoa_poc/meson_cross.template:
https://review.coreboot.org/c/coreboot/+/76511/comment/5f6643a6_c68bad76 : PS14, Line 17: # openSIL isn't compatible with coreboot's assert implementation, so use special case : '-D_PORTING_H_=1', : '-DSIL_DEBUG_ENABLE=##SIL_DEBUG_ENABLE##', : # openSIL uses coreboot assert which uses printk which warns about unused-param These two comments seem to contradict each other.