Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Scott Chao.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79244?usp=email )
Change subject: mb/google/nissa: update GPP_F17 to edge trigger
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
interesting, we didn't find this in nivviks I think :)
The interrupt storm only happens with ITE ECs, not Nuvoton. I think changing it to edge triggered is correct regardless based on the spec linked from b/308539814#comment11: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/12_ACPI_Embedded_Controller_In... But there is still something unexplained about the ITE vs nuvoton behaviour.
Also I tested that wake still works on craask with this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79244?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff
Gerrit-Change-Number: 79244
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 22 Nov 2023 23:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment